-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suport for drop/take messages to map lanes. #738
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 49.36% 49.34% -0.02%
==========================================
Files 401 401
Lines 34821 34994 +173
==========================================
+ Hits 17190 17269 +79
- Misses 17631 17725 +94 ☔ View full report in Codecov by Sentry. |
|
||
impl<C, K, V> MapLaneDropOrTake<C, K, V> { | ||
fn new( | ||
projection: for<'a> fn(&'a C) -> &'a MapLane<K, V>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the Java implementation, should this not be something like projection: for<'a> fn(&'a C) -> &'a MapLane<K, V, BTreeMap<K, V>>
(once your abstraction PR has been merged)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The next PR adds an optimization that alters how it computes the prefixes/suffixes for the case where the backing map is ordered, so it will be more efficient for BTreeMap
(and falls back to this implementation for HashMap
).
Co-authored-by: Thomas Klapwijk <[email protected]>
Removes unused iterator module from the persistence crate.
Adds support for drop/take messages to map lanes.