-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstracts MapStore
and MapLane
over the underlying map implementation.
#739
Open
horned-sphere
wants to merge
15
commits into
cleanup
Choose a base branch
from
flexible-maps
base: cleanup
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the agent derive macro so that it does not require the backing store for map items to be HashMap.
Extended derive macro for AgentLaneModel.
Adds test cases for map lane and stores with ordered maps.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cleanup #739 +/- ##
===========================================
+ Coverage 49.37% 49.40% +0.03%
===========================================
Files 401 401
Lines 34942 34957 +15
===========================================
+ Hits 17251 17269 +18
+ Misses 17691 17688 -3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
SirCipher
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to change the underlying map used by
MapStore
andMapLane
. This allows:MapLane<K, V, HashMap<K, V, S>>
- Specifying a custom hash implementation for hash maps.MapLane<K, V, BTreeMap<K, V>>
- Specifying an ordered standard library B-tree map.This behaviour is enabled by two new traits
swimos_agen::map_storage::MapOps
andswimos_agen::map_storage::MapOpsWithEntry
. Currently these are only implement for the standard libraryHashMap
andBTreeMap
types and are not exposed in the public API (so uses can't add support for more map types).The type of the map is optional and:
MapLane<K, V> == MapLane<K, V, HashMap<K, V>>