Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE8 bug fix for drop down #86

Open
wants to merge 1 commit into
base: 2.1
Choose a base branch
from
Open

IE8 bug fix for drop down #86

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions javascript/Attribute_OptionField.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,11 @@
if(variations.hasOwnProperty(key)){

var variationOptions = variations[key]['options'];
if (variationOptions.filter(function(elem) {
return partial.indexOf(elem) > -1;
}).length == partial.length) {
// Remove so will work on IE8 and all other browsers
// if (variationOptions.filter(function(elem) {
// return partial.indexOf(elem) > -1;
// }).length == partial.length) {
if (variationOptions.length == partial.length) {

//check if the option getting added does not already exist in the dropdown (to avoid duplicate options)
if ($('option[value='+val+']',self).length == 0) {
Expand Down