Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(components): set header z-index #4400

Closed
wants to merge 2 commits into from
Closed

Conversation

myrta2302
Copy link
Contributor

No description provided.

@myrta2302 myrta2302 linked an issue Jan 9, 2025 that may be closed by this pull request
1 task
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: 52832d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@swisspost/design-system-components Patch
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Patch
@swisspost/design-system-documentation Patch
@swisspost/design-system-components-angular Patch
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-styles Patch
@swisspost/design-system-tokens Patch
@swisspost/design-system-intranet-header Patch
@swisspost/design-system-icons Patch
@swisspost/design-system-migrations Patch
@swisspost/design-system-styles-primeng Patch
@swisspost/internet-header Patch
@swisspost/design-system-intranet-header-workspace Patch
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-intranet-header-showcase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarqubecloud bot commented Jan 9, 2025

@swisspost-bot
Copy link
Contributor

swisspost-bot commented Jan 9, 2025

@myrta2302
Copy link
Contributor Author

This only ensures that the header is stacked on top of other elements - including the popover (trigger). The popovercontainer issue still remains (since it belongs to the #toplayer and is stacked above everything). This probably needs to be resolved with setting the post-header as a boundary via the floating ui API.

@myrta2302 myrta2302 marked this pull request as ready for review January 9, 2025 07:51
@myrta2302 myrta2302 requested a review from a team as a code owner January 9, 2025 07:51
@myrta2302 myrta2302 requested review from leagrdv and alizedebray and removed request for leagrdv January 9, 2025 07:51
@myrta2302 myrta2302 marked this pull request as draft January 9, 2025 14:46
@myrta2302 myrta2302 closed this Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix header z-index
2 participants