feat(utilities): rename viewport-based sizing utility classes #6191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb06906 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
leagrdv
requested changes
Sep 10, 2025
leagrdv
requested changes
Sep 16, 2025
leagrdv
requested changes
Sep 16, 2025
update documentation
|
leagrdv
requested changes
Sep 30, 2025
Comment on lines
+60
to
+61
| > - `vw-quarter`, `vw-third`, `vw-half`, `vw-two-thirds`, `vw-three-quarters`, `vw-full` | ||
| > - `vh-quarter`, `vh-third`, `vh-half`, `vh-two-thirds`, `vh-three-quarters`, `vh-full` |
There was a problem hiding this comment.
Suggested change
| > - `vw-quarter`, `vw-third`, `vw-half`, `vw-two-thirds`, `vw-three-quarters`, `vw-full` | |
| > - `vh-quarter`, `vh-third`, `vh-half`, `vh-two-thirds`, `vh-three-quarters`, `vh-full` | |
| > - `vw-{suffix}`, `vh-{suffix}` |
| ${samples.map( | ||
| sample => html` | ||
| <div class="grid-item snapshot"> | ||
| <div class="${generateClassNames(sample, true)}"></div> |
There was a problem hiding this comment.
Only the vw and vh classes are being tested here, please update generateClassNames to also have tests for min and max
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR renames viewport-based sizing utility classes from numeric values to named variants for consistency with percentage utilities.
🚀 Demo
If applicable, please add a screenshot or video to illustrate the changes.
📝 Checklist