fix(docs): fix dialog markup on dialog text content and button intendation #6206
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e98213c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Related Previews |
…es with `flexdirection: column` on dialog styles
alionazherdetska
requested changes
Sep 25, 2025
alizedebray
requested changes
Sep 26, 2025
…es in Dialog stories
alionazherdetska
approved these changes
Oct 1, 2025
|
alizedebray
requested changes
Oct 3, 2025
Comment on lines
+123
to
124
| return html`<button class="btn btn-primary">OK</button><br /> | ||
| <button class="btn btn-secondary">Cancel</button>`; |
There was a problem hiding this comment.
The code should remain the same, we do not want to change the dialog component.
The ticket is about code formatting, for a good indentation the button tags must be on two different lines:
Suggested change
| return html`<button class="btn btn-primary">OK</button><br /> | |
| <button class="btn btn-secondary">Cancel</button>`; | |
| return html` | |
| <button class="btn btn-primary">OK</button> | |
| <button class="btn btn-secondary">Cancel</button> | |
| `; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
<p>-tag around dialog content in stories, required for accessibility.<button>-tags to be on two different lines.