-
Notifications
You must be signed in to change notification settings - Fork 20
chore(components): update <post-menu>
and <post-popovecontainer>
to enforce separation of concerns
#6357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore(components): update <post-menu>
and <post-popovecontainer>
to enforce separation of concerns
#6357
Conversation
…n-to-use-web-animations-api
…n-to-use-web-animations-api
…n-to-use-web-animations-api
…b-animations-api' of https://github.com/swisspost/design-system into 5463-refactor-post-popovercontainer-animation-to-use-web-animations-api
…n-to-use-web-animations-api
…n-to-use-web-animations-api
…n-to-use-web-animations-api
…-trigger-and-post-menu-items-when-nvda-is-running
…d-post-menu-items-when-nvda-is-running' of https://github.com/swisspost/design-system into 5837-bug-accessibility-issues-with-post-menu-trigger-and-post-menu-items-when-nvda-is-running
…-trigger-and-post-menu-items-when-nvda-is-running
…ner-animation-to-use-web-animations-api' into 6341-update-post-menu-and-post-popovecontainer-to-enforce-separation
🦋 Changeset detectedLatest commit: fe2f062 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Related Previews |
<post-menu>
and `<post-popovecontainer> to enforce separation of concerns<post-menu>
and <post-popovecontainer>
to enforce separation of concerns
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Outdated
Show resolved
Hide resolved
|
📄 Description
This PR updates the
<post-popovercontainer>
component by adding the following events:making use of the new animation implementation, based on the Web Animations API.
Additionally, the
<post-menu>
component has been updated to:🚀Preview Link
https://preview-6357--swisspost-design-system-next.netlify.app/?path=/docs/8ca2bd70-56e6-4da9-b1fd-4e55388dca88--docs
📝 Checklist