Skip to content

Conversation

leagrdv
Copy link
Contributor

@leagrdv leagrdv commented Oct 1, 2025

📄 Description

  • Replaced the .btn-close class with the post-closebutton component in dialog, toast and post-popover
  • Added a button-type property to the post-closebutton in order to be able to set a submit type for the dialog
  • Moved style for close button in the components folder
  • Deleted the .btn-close and .btn-close-white (deprecated) classes
  • Removed the notification-dismissible mixin as it was only used for the toast
  • Removed all close variables as they were no longer used

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@leagrdv leagrdv requested review from a team as code owners October 1, 2025 14:10
@leagrdv leagrdv requested a review from alizedebray October 1, 2025 14:10
Copy link

changeset-bot bot commented Oct 1, 2025

🦋 Changeset detected

Latest commit: ba507d5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@swisspost/design-system-components Major
@swisspost/design-system-documentation Patch
@swisspost/design-system-styles Major
@swisspost/design-system-components-angular-workspace Patch
@swisspost/design-system-components-react Major
@swisspost/design-system-nextjs-integration Patch
@swisspost/design-system-components-angular Major
@swisspost/internet-header Major
@swisspost/design-system-styles-primeng-workspace Patch
@swisspost/design-system-styles-primeng Major
@swisspost/design-system-tokens Major
@swisspost/design-system-icons Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@leagrdv leagrdv linked an issue Oct 1, 2025 that may be closed by this pull request
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Oct 1, 2025

Related Previews

@leagrdv leagrdv marked this pull request as draft October 1, 2025 15:00
@leagrdv leagrdv removed the request for review from alizedebray October 1, 2025 15:00
@leagrdv leagrdv marked this pull request as ready for review October 2, 2025 09:27
@myrta2302 myrta2302 self-requested a review October 7, 2025 15:21
@myrta2302 myrta2302 requested a review from alizedebray October 9, 2025 06:31
Copy link

sonarqubecloud bot commented Oct 9, 2025

@leagrdv leagrdv requested a review from alizedebray October 9, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace .btn-close with post-closebutton

4 participants