-
Notifications
You must be signed in to change notification settings - Fork 21
chore(components-angular): add missing components markup to Angular consumer-app
#6604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(components-angular): add missing components markup to Angular consumer-app
#6604
Conversation
…ntegration package
|
consumer-app
ac8c770 to
9c10643
Compare
…ponents-markup-to-angular-integration-package
…ponents-markup-to-angular-integration-package
e59f98e to
2f48bcc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances component testing infrastructure and fixes hydration issues across the design system. It adds comprehensive error capture mechanisms for Playwright and Cypress tests, improves the Angular consumer app with a complete header/footer implementation, and fixes a null pointer issue in the post-megadropdown component.
- Added new test coverage for component hydration and console error detection
- Fixed post-megadropdown component to safely disconnect observer during cleanup
- Expanded Angular consumer app with full header, navigation, breadcrumbs, and footer implementations
Reviewed Changes
Copilot reviewed 6 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/nextjs-integration/playwright/tests/ssr.spec.ts | Added new tests for component hydration status and console error detection |
| packages/nextjs-integration/playwright/tests/csr.spec.ts | Added new tests for component hydration status and console error detection |
| packages/components-angular/projects/consumer-app/cypress/e2e/components.cy.ts | Refactored component tests to use component-names.json and added error capture testing |
| packages/components/src/components/post-menu/post-menu.tsx | Added newline at end of file for consistent formatting |
| packages/components/src/components/post-megadropdown/post-megadropdown.tsx | Added null check before disconnecting observer to prevent errors during component cleanup |
| packages/components-angular/projects/consumer-app/src/app/routes/home/home.component.ts | Reorganized imports alphabetically and added missing component imports (PostLinkarea, PostMenu, PostTooltip, etc.) |
| packages/components-angular/projects/consumer-app/src/app/routes/home/home.component.html | Replaced PostLogo example with PostLinkarea, added PostMenu and complete PostTooltip examples |
| packages/nextjs-integration/src/app/ssr/page.tsx | Removed duplicate link from card-link example |
| packages/components-angular/projects/consumer-app/src/app/app.module.ts | Migrated AppComponent to standalone by moving from declarations to imports |
| packages/components-angular/projects/consumer-app/src/app/app.component.ts | Converted to standalone component with complete header/footer data structures and navigation config |
| packages/components-angular/projects/consumer-app/src/app/app.component.html | Implemented complete application shell with PostHeader, PostMainnavigation, PostBreadcrumbs, and PostFooter |
packages/components-angular/projects/consumer-app/src/app/routes/home/home.component.html
Outdated
Show resolved
Hide resolved
packages/components-angular/projects/consumer-app/src/app/app.component.ts
Outdated
Show resolved
Hide resolved
|



📄 Description
This PR is adding missing component markup to the Angular consumer-app.
Findings
Integrating PostHeader into the Angular consumer-app revealed a latent bug in PostMegadropdown's cleanup logic during Cypress testing: an issue that had gone undetected until then.

Fix
PostMegadropdown component (
post-megadropdown.tsx):defaultSlotObserverin thedisconnectedCallback()lifecycle method🔮 Design review
📝 Checklist