Skip to content

Conversation

@alionazherdetska
Copy link
Contributor

@alionazherdetska alionazherdetska commented Nov 6, 2025

📄 Description

This PR is adding missing component markup to the Angular consumer-app.

Findings

Integrating PostHeader into the Angular consumer-app revealed a latent bug in PostMegadropdown's cleanup logic during Cypress testing: an issue that had gone undetected until then.
Screenshot 2025-11-07 124909

Fix

PostMegadropdown component (post-megadropdown.tsx):

  • Added null check guard before disconnecting defaultSlotObserver in the disconnectedCallback() lifecycle method
  • This prevents errors during component teardown when the observer may not have been initialized

🔮 Design review

  • Design review done
  • No design review needed

📝 Checklist

  • ✅ My code follows the style guidelines of this project
  • 🛠️ I have performed a self-review of my own code
  • 📄 I have made corresponding changes to the documentation
  • ⚠️ My changes generate no new warnings or errors
  • 🧪 I have added tests that prove my fix is effective or that my feature works
  • ✔️ New and existing unit tests pass locally with my changes

@alionazherdetska alionazherdetska requested a review from a team as a code owner November 6, 2025 15:19
@alionazherdetska alionazherdetska requested review from leagrdv and removed request for a team November 6, 2025 15:19
@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2025

⚠️ No Changeset found

Latest commit: 0c8b361

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alionazherdetska alionazherdetska marked this pull request as draft November 6, 2025 15:19
@alionazherdetska alionazherdetska changed the title chore(components-angular): add missing components markup to angular integration package chore(components-angular): add missing components markup to Angular consumer-app Nov 6, 2025
@swisspost-bot
Copy link
Contributor

swisspost-bot commented Nov 6, 2025

Related Previews

@alionazherdetska alionazherdetska force-pushed the add-missing-components-markup-to-angular-integration-package branch from ac8c770 to 9c10643 Compare November 7, 2025 13:35
…ponents-markup-to-angular-integration-package
@alionazherdetska alionazherdetska marked this pull request as ready for review November 7, 2025 13:37
@alionazherdetska alionazherdetska force-pushed the add-missing-components-markup-to-angular-integration-package branch from e59f98e to 2f48bcc Compare November 7, 2025 14:48
@alionazherdetska alionazherdetska changed the base branch from e2e-tabs-component-angular-nextjs to main November 10, 2025 06:28
Copilot AI review requested due to automatic review settings November 10, 2025 06:34
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances component testing infrastructure and fixes hydration issues across the design system. It adds comprehensive error capture mechanisms for Playwright and Cypress tests, improves the Angular consumer app with a complete header/footer implementation, and fixes a null pointer issue in the post-megadropdown component.

  • Added new test coverage for component hydration and console error detection
  • Fixed post-megadropdown component to safely disconnect observer during cleanup
  • Expanded Angular consumer app with full header, navigation, breadcrumbs, and footer implementations

Reviewed Changes

Copilot reviewed 6 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
packages/nextjs-integration/playwright/tests/ssr.spec.ts Added new tests for component hydration status and console error detection
packages/nextjs-integration/playwright/tests/csr.spec.ts Added new tests for component hydration status and console error detection
packages/components-angular/projects/consumer-app/cypress/e2e/components.cy.ts Refactored component tests to use component-names.json and added error capture testing
packages/components/src/components/post-menu/post-menu.tsx Added newline at end of file for consistent formatting
packages/components/src/components/post-megadropdown/post-megadropdown.tsx Added null check before disconnecting observer to prevent errors during component cleanup
packages/components-angular/projects/consumer-app/src/app/routes/home/home.component.ts Reorganized imports alphabetically and added missing component imports (PostLinkarea, PostMenu, PostTooltip, etc.)
packages/components-angular/projects/consumer-app/src/app/routes/home/home.component.html Replaced PostLogo example with PostLinkarea, added PostMenu and complete PostTooltip examples
packages/nextjs-integration/src/app/ssr/page.tsx Removed duplicate link from card-link example
packages/components-angular/projects/consumer-app/src/app/app.module.ts Migrated AppComponent to standalone by moving from declarations to imports
packages/components-angular/projects/consumer-app/src/app/app.component.ts Converted to standalone component with complete header/footer data structures and navigation config
packages/components-angular/projects/consumer-app/src/app/app.component.html Implemented complete application shell with PostHeader, PostMainnavigation, PostBreadcrumbs, and PostFooter

@alionazherdetska alionazherdetska requested a review from a team as a code owner November 10, 2025 06:55
@sonarqubecloud
Copy link

@alionazherdetska alionazherdetska merged commit 0f086ae into main Nov 10, 2025
14 checks passed
@alionazherdetska alionazherdetska deleted the add-missing-components-markup-to-angular-integration-package branch November 10, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants