chore(components): fix popovercontainer animation bug affecting tooltip functionality #6607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e231f74 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
myrta2302
requested review from
oliverschuerch
and removed request for
alizedebray
Contributor
oliverschuerch
requested changes
Nov 10, 2025
| * Animation style | ||
| */ | ||
| @Prop() readonly animation?: 'pop-in' | null = null; | ||
| @Prop() readonly animation?: 'pop-in' | null = 'pop-in'; |
Contributor
There was a problem hiding this comment.
Why is this necessary, to fix the bug related to the animation?
Don't we handle that with your other PR?
Contributor
Author
There was a problem hiding this comment.
That was left there by mistake. I ll revert it.
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Outdated
Show resolved
Hide resolved
…overing-inout-too-fast-and-animation-is-used
oliverschuerch
requested changes
Nov 10, 2025
Contributor
oliverschuerch
left a comment
oliverschuerch
left a comment
There was a problem hiding this comment.
postBeforeToggle and postBeforeShow are actually the same lifecycle hooks, just with different payloads.
This is not to be fixed here, but it could be an improvement in the future.
Same is true for postToggle and postShow.
It would be possible to combine the payload of them and end up having only two events, instead of four.
packages/components/src/components/post-popovercontainer/post-popovercontainer.tsx
Show resolved
Hide resolved
oliverschuerch
approved these changes
Nov 10, 2025
|
oliverschuerch
approved these changes
Nov 10, 2025
myrta2302
deleted the
6606-bug-tooltip-functionality-breaks-when-hovering-inout-too-fast-and-animation-is-used
branch
gfellerph
pushed a commit
that referenced
this pull request
Nov 10, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ `main` is currently in **pre mode** so this branch has prereleases rather than normal releases. If you want to exit prereleases, run `changeset pre exit` on `main`.⚠️ ⚠️ ⚠️ ⚠️ ⚠️ ⚠️ # Releases ## @swisspost/[email protected] ### Minor Changes - Updated the `post-header` to use aria-current="location" for active header links outside main navigation to improve accessibility. (by [@myrta2302](https://github.com/myrta2302) with [#6566](#6566)) ### Patch Changes - Updated `post-popovercontainer` to fix a tooltip desynchronization issue when hovering quickly in and out. (by [@myrta2302](https://github.com/myrta2302) with [#6607](#6607)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Added icons: `2741` (by [@swisspost-bot](https://github.com/swisspost-bot) with [#6588](#6588)) ## @swisspost/[email protected] ### Minor Changes - Updated the `post-header` to use aria-current="location" for active header links outside main navigation to improve accessibility. (by [@myrta2302](https://github.com/myrta2302) with [#6566](#6566)) ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ## @swisspost/[email protected] ### Minor Changes - Updated the `post-header` to use aria-current="location" for active header links outside main navigation to improve accessibility. (by [@myrta2302](https://github.com/myrta2302) with [#6566](#6566)) ### Patch Changes - Updated the migration guide to improve clarity and usability, making it more user-friendly and understandable, and added detailed instructions for removing Bootstrap and Ng-Bootstrap along with general migration guidance. (by [@leagrdv](https://github.com/leagrdv) with [#6565](#6565)) - Updated several outdated Figma links to point to the correct design. (by [@leagrdv](https://github.com/leagrdv) with [#6592](#6592)) - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] - @swisspost/[email protected] ## @swisspost/[email protected] ### Patch Changes - Updated dependencies: - @swisspost/[email protected] --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Description
This PR updates the popovercontainer animation logic to fix a timing issue that happened when users hovered in and out quickly, causing the tooltip to get out of sync.
📝 Checklist