Skip to content

Commit

Permalink
Merge pull request #20 from swisspost/develop
Browse files Browse the repository at this point in the history
PR for release
  • Loading branch information
mcweba authored Jan 18, 2024
2 parents 5135b6a + 9b7f3bf commit 5c9c3a7
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/maven.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: Release to maven central
if: github.ref_name == 'master' && github.event_name != 'pull_request' && github.repository == 'swisspost/mod-metrics'
run: |
curl -s get.sdkman.io | bash
curl -s https://get.sdkman.io | bash
source "$HOME/.sdkman/bin/sdkman-init.sh"
sdk install groovy 3.0.8
Expand Down
12 changes: 6 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
[![Maven Central](https://img.shields.io/maven-central/v/org.swisspush/mod-metrics.svg)]()
[![GitHub contributors](https://img.shields.io/github/contributors/swisspush/mod-metrics.svg)](https://github.com/swisspush/mod-metrics/graphs/contributors)

A vert.x mod to try and expose stats over JMX using the [Metrics](https://metrics.dropwizard.io/4.0.0/)
A vert.x mod to try and expose stats over JMX using the [Metrics](https://metrics.dropwizard.io/4.2.0/)
library.

Default config:
Expand All @@ -31,7 +31,7 @@ The mod accepts the messages below.
`set` on a metric already constructed with `inc`) then I suspect things will
blow up in (not so) interesting ways.

## Gauges (see [here](https://metrics.dropwizard.io/4.0.0/manual/core.html#gauges))
## Gauges (see [here](https://metrics.dropwizard.io/4.2.0/manual/core.html#gauges))

NB: Only accepts Integer values

Expand All @@ -43,7 +43,7 @@ NB: Only accepts Integer values
n : 128
}

## Counters (see [here](https://metrics.dropwizard.io/4.0.0/manual/core.html#counters))
## Counters (see [here](https://metrics.dropwizard.io/4.2.0/manual/core.html#counters))

### incrementing

Expand All @@ -61,7 +61,7 @@ NB: Only accepts Integer values
n : 1 // Optional, defaults to 1
}

## Meters (see [here](https://metrics.dropwizard.io/4.0.0/manual/core.html#meters))
## Meters (see [here](https://metrics.dropwizard.io/4.2.0/manual/core.html#meters))

### mark

Expand All @@ -70,7 +70,7 @@ NB: Only accepts Integer values
action : "mark"
}

## Histograms (see [here](https://metrics.dropwizard.io/4.0.0/manual/core.html#histograms))
## Histograms (see [here](https://metrics.dropwizard.io/4.2.0/manual/core.html#histograms))

### update

Expand All @@ -80,7 +80,7 @@ NB: Only accepts Integer values
n : 10
}

## Timers (see [here](https://metrics.dropwizard.io/4.0.0/manual/core.html#timers))
## Timers (see [here](https://metrics.dropwizard.io/4.2.0/manual/core.html#timers))

If you start a timer, then the `Context` for that timer is stored in a `Map`. Not
stopping the timer will cause this Context to persist in-perpetuity.
Expand Down
8 changes: 4 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>org.swisspush</groupId>
<artifactId>mod-metrics</artifactId>
<version>3.0.2-SNAPSHOT</version>
<version>3.1.0-SNAPSHOT</version>
<name>mod-metrics</name>
<description>Vert.x Metrics module for JMX reporting</description>
<url>https://github.com/swisspush/mod-metrics</url>
Expand Down Expand Up @@ -39,9 +39,9 @@
<repositoryId />
<maven.compiler.source>11</maven.compiler.source>
<maven.compiler.target>11</maven.compiler.target>
<vertx.version>4.2.1</vertx.version>
<junit.version>4.11</junit.version>
<core-metrics.version>4.0.2</core-metrics.version>
<vertx.version>4.5.1</vertx.version>
<junit.version>4.13.2</junit.version>
<core-metrics.version>4.2.23</core-metrics.version>
</properties>

<repositories>
Expand Down
1 change: 0 additions & 1 deletion src/main/java/org/swisspush/metrics/MetricsModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import com.codahale.metrics.Timer.Context;
import com.codahale.metrics.jmx.JmxReporter;
import io.vertx.core.AbstractVerticle;
import io.vertx.core.Future;
import io.vertx.core.Handler;
import io.vertx.core.Promise;
import io.vertx.core.eventbus.Message;
Expand Down

0 comments on commit 5c9c3a7

Please sign in to comment.