Fix misleading log #218
Merged
Fix misleading log #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ves the log from is NOT where the process has completed, but TOO EARLY. Because other scheduled task runs may are STILL IN PROGRESS. And the log line is reached TOO EARLY there, and therefore would log a way too short (aka misleading) duration. The only place where the method call is really done, is as where the returned future is resolved. Relates to: - PR 216
Kusig
approved these changes
Oct 29, 2024
|
thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The place where the log was, is NOT where the process has completed, but TOO EARLY. Because other scheduled task runs may are STILL IN PROGRESS when this line is reached. Therefore would log a way too short (aka misleading) duration.
The only place where the method call is really done, is as where the returned future is resolved.