Log number of queues locked on a per RedisQues Verticle instance base #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcweba
reviewed
Nov 7, 2024
use scan to get the keys
mcweba
reviewed
Nov 11, 2024
| @@ -430,12 +430,12 @@ private void registerNotExpiredQueueCheck() { | |||
| } | |||
| String keysPattern = consumersPrefix + "*"; | |||
| log.debug("RedisQues list not expired consumers keys:"); | |||
| redisProvider.redis().onSuccess(redisAPI -> redisAPI.keys(keysPattern, keysResult -> { | |||
| if (keysResult.failed() || keysResult.result() == null) { | |||
| redisProvider.redis().onSuccess(redisAPI -> redisAPI.scan(Arrays.asList("0", "MATCH", keysPattern, "COUNT", "1000"), keysResult -> { | |||
There was a problem hiding this comment.
I never used scan myself but don't you have to have to iterate over the whole keys by using the cursor?
There was a problem hiding this comment.
See screenshot, this is not needed
There was a problem hiding this comment.
See screenshot, this is not needed
I don't see why it is not needed. In the screenshot you were "lucky" to got "0" as cursor index result. When this is number higher than "0" you have to iterate again. The SCAN command does not return all results, but at most the number you defined ("1000).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR we periodically (every 20s) log how many queues each verticle instance is currently processing. This is done only if the log level is at least DEBUG. "Currently processing" means that the verticle has placed a so called "consumer lock" onto the queue.
Additionally some output is now logged on TRACE level to avoid overload when set to DEBUG.