Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ICERM CCE Feedback #6246

Open
2 of 7 tasks
nilsdeppe opened this issue Aug 24, 2024 · 1 comment
Open
2 of 7 tasks

ICERM CCE Feedback #6246

nilsdeppe opened this issue Aug 24, 2024 · 1 comment
Assignees

Comments

@nilsdeppe
Copy link
Member

nilsdeppe commented Aug 24, 2024

Here are notes I took at ICERM from feedback I got from various folks on how we could improve CCE usability.

  • A grid point-based approach would be helpful where we give people the grid point locations to dump and they can dump the metric and derivatives there.
    • Zach would like radial derivatives
    • ETK would like Cartesian derivatives.
  • We should have a glob-approach and then combine the HDF5 file on the fly so that people don’t need to do combine-h5 or something to get a single file. One option would be to make the combine-h5 distributed, but it would be even easier for users if we just do the combine before starting the CCE computation.
    1. Add HDF5 combining to CceReduceWorldtube by giving folks the ability to specify a glob for the file names. E.g. Lev1_*/Run/CceOutputR0215.h5
    2. There may be overlapping times in the files. We need to remove these. We should have an option to select times from either the earlier or later file. Ideally the data should be the same, but I don't think we need to check that. ETK uses first file.
  • We need to document reasonable temporal sampling for the worldtube input. That is, how often should people dump worldtube data? We should provide some heuristic advice and comment on inspiral vs. merger since the time scales change. I would guess in SpEC and SpECTRE we get around this by dump some every N steps, but I don't know. @keefemitman @markscheel could you comment on how we decide how frequently to dump the worldtube?
  • Could we compress the files? E.g. RPDMB, spectral fit in time? This is lower priority compared to the other points.
  • Document the Ylm convention we assume since there are different ones. This probably is just pointing to spherepack docs, roughly speaking. @nilsdeppe can add this. (Document CCE grid point locations for Ylms #6271 )
  • We should provide an executable that dumps a text file of the theta & phi (or maybe 2 files) coordinates to use for a given ell. @knelli2 is working on this. (Add executable to write CCE worldtube coords to a file #6284 )
  • We should provide a C++ routine that takes in a given ell and returns the theta and phi points that need to be dumped to. @nilsdeppe will do this. The idea is to have a function in a test file that computes the points and then we have a snippet in the documentation. We can then test that the function returns the correct values for different ell. (Document CCE grid point locations for Ylms #6271 )
@knelli2
Copy link
Contributor

knelli2 commented Aug 24, 2024

  1. SpEC observes 400 times per orbit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants