Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More miscellaneous CCE changes #6396

Merged
merged 7 commits into from
Dec 6, 2024

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Dec 5, 2024

Proposed changes

Some more miscellaneous CCE changes needed for the updates in #6246. The more substantial changes will come in follow-up PRs.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few suggestions you can squash right away

src/Evolution/Systems/Cce/BoundaryData.cpp Outdated Show resolved Hide resolved
src/Evolution/Systems/Cce/BoundaryData.cpp Outdated Show resolved Hide resolved
src/Evolution/Systems/Cce/WorldtubeModeRecorder.hpp Outdated Show resolved Hide resolved
src/Evolution/Systems/Cce/WorldtubeBufferUpdater.hpp Outdated Show resolved Hide resolved
@nilsdeppe nilsdeppe merged commit 64ffd9c into sxs-collaboration:develop Dec 6, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants