Update ReduceCceWorldtube with new features #6398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
added
in progress
knelli2
force-pushed
the
reduce_cce_combine_h5
branch
2 times, most recently
from
bf2c7bf to
d814ef7
Compare
knelli2
removed
the
in progress
knelli2
force-pushed
the
reduce_cce_combine_h5
branch
2 times, most recently
from
4d57b86 to
5327598
Compare
nilsdeppe
requested changes
Dec 13, 2024
knelli2
force-pushed
the
reduce_cce_combine_h5
branch
from
5327598 to
3da4b46
Compare
|
@nilsdeppe I pushed a fixup and added a new commit that adds this small exec which writes the collocation points to a text file to the statically deployed execs. Then in the last commit I just additionally renamed the new things I added |
nilsdeppe
reviewed
Dec 13, 2024
| @@ -199,6 +202,14 @@ supports \f$\ell\in[4, 32]\f$. | |||
| \snippet Test_Spherepack.cpp spectre_cce_grid_point_locations | |||
| </details> | |||
|
|
|||
| Alternatively, if your code can read in grid points from a text file, you can | |||
There was a problem hiding this comment.
text file or h5? Because the -o below is with a .h5. You can do this when you squash :)
The worldtube data can now be one of MetricModal, MetricNodal, BondiModal, BondiNodal. Also, the executable can now combine multiple H5 files into one.
knelli2
force-pushed
the
reduce_cce_combine_h5
branch
from
3da4b46 to
2fad23b
Compare
nilsdeppe
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The worldtube data can now be metric modal/nodal or bondi modal/nodal and the executable can temporally combine H5 files before transforming the worldtube data into bondi modal form.
Upgrade instructions
There are two new options for the ReduceCceWorldtube executable. They are
InputDataFormat:andExtractionRadius:. Also theInputH5Fileoption can now be either a single filename or a list of filenames to combine temporally.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
Depends on and includes #6396, #6397.