Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import FUKA initial data #5339

Merged
merged 5 commits into from
Oct 2, 2023
Merged

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Aug 11, 2023

Proposed changes

On CaltechHPC load the fuka/2023-08 module (in module use /central/groups/sxs/modules), then configure the CMake build (or set FUKA_ROOT yourself).

To use this set InitialData in a GHMHD input file to something like this:

InitialData:
  FukaInitialData:
    InfoFilename: /central/groups/sxs/emost/fuka/codes/PythonTools/Example_id/converged_BNS_TOTAL.togashi.30.6.0.0.2.8.q1.0.0.09.info
    ElectronFraction: 0.15

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu
Copy link
Member Author

nilsvu commented Aug 11, 2023

@ermost want to give this a try? When loading some sample ID in the FUKA repo I'm getting an FPE in Kadath, but that might be because my domain wasn't set up correctly or something like that.

@nilsvu nilsvu mentioned this pull request Aug 11, 2023
3 tasks
get<0, 1>(spatial_metric) = to_datavector(fuka_data[5]);
get<0, 2>(spatial_metric) = to_datavector(fuka_data[6]);
get<1, 1>(spatial_metric) = to_datavector(fuka_data[7]);
get<0, 2>(spatial_metric) = to_datavector(fuka_data[8]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 1,2?

It seems like you are not setting gamma_yz?

Copy link
Member Author

@nilsvu nilsvu Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed! The FPE happens in Kadath though, so I don't think this was it..

Also I'd like to add a test for this that is enabled only when FUKA is available. Maybe we could put some sample data into the FUKA install directory? Do you think some of the data in the FUKA repo would be appropriate, or should we generate new data?

src/IO/External/InterpolateFromFuka.cpp Outdated Show resolved Hide resolved
@ermost
Copy link
Contributor

ermost commented Aug 11, 2023

Sure, happy to take a look.

@nilsvu nilsvu force-pushed the import_fuka branch 3 times, most recently from 56936b9 to c5cb1e1 Compare August 17, 2023 00:23
@nilsvu nilsvu force-pushed the import_fuka branch 2 times, most recently from b3ea2d1 to b0fe0a0 Compare September 26, 2023 18:28
@nilsvu nilsvu marked this pull request as ready for review September 26, 2023 18:28
@nilsvu
Copy link
Member Author

nilsvu commented Sep 26, 2023

This is ready for review now.

@nilsvu
Copy link
Member Author

nilsvu commented Sep 28, 2023

I successfully evolved some FUKA BNS ID with this. Here's the initial frame:

Bildschirmfoto 2023-09-27 um 22 48 42

@nilsvu
Copy link
Member Author

nilsvu commented Sep 28, 2023

Can't fix the remaining clang-tidy warnings I think.

Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash

cmake/FindFUKA.cmake Show resolved Hide resolved
static constexpr Options::String help = {
"Path to the '.info' file of data produced by FUKA."};
};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a comment here or in the help string that the constant electron fraction option is most of the time inconsistent with the ID, and will need to be replaced later?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let's do that! Does the ID write out consistent a electron fraction? If not, should that be added? We've talked about this for SpEC too, and that's the plan for spec

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither electron fraction nor temperature are written out by FUKA. I added a note to the dox for this class and opened #5518.

@nilsvu nilsvu merged commit 4de07c1 into sxs-collaboration:develop Oct 2, 2023
@nilsvu nilsvu deleted the import_fuka branch October 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants