Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite BoundaryHistory to support substeps #5461

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Sep 15, 2023

If reviewers prefer, the second and third commits could be moved to a separate PR.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Copy link
Member

@kidder kidder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I like the rewrite and I have no requested changes.
  • clang-tidy has flagged some moves of trivially-copyable type
  • gcc11 is not compiling the print function, maybe need a using ::operator<<; or an include in the test?

@wthrowe
Copy link
Member Author

wthrowe commented Sep 21, 2023

I can reproduce the gcc 11 problem locally, but I'm not having any luck fixing it. Adding using ::operator<<; immediately before the problematic line and including Utilities/StdHelpers.hpp as the first thing in the compilation unit doesn't do anything. Calling operator<< directly either doesn't do anything of gives an error about ambiguity (I think in a different call) depending on exactly how I do it.

@wthrowe
Copy link
Member Author

wthrowe commented Sep 29, 2023

gcc 11 fixed. Search for print_stl if you want to see how.

kidder
kidder previously approved these changes Sep 29, 2023
@kidder
Copy link
Member

kidder commented Oct 2, 2023

Hi @wthrowe some of the clang-tidy errors are ones we have fixed in the past

error: parameter 'entry' is const-qualified in the function declaration; const-qualification of parameters only has an effect in function definitions [readability-avoid-const-params-in-decls,-warnings-as-errors]

@wthrowe
Copy link
Member Author

wthrowe commented Oct 3, 2023

Disabled some checks in a new commit, fixed the rest. Also deleted an internal function that was never used.

Leaving out the move constructor and assignment operator is not the
same as either explicitly defaulting or deleting them, so this error
is difficult to act on.
@wthrowe wthrowe added the in progress Don't review, used for sharing code and getting feedback label Oct 3, 2023
This does not include support for substeps.  That will be added later.
@wthrowe wthrowe removed the in progress Don't review, used for sharing code and getting feedback label Oct 4, 2023
@nilsdeppe
Copy link
Member

I confirmed with @kidder that this can get merged

@nilsdeppe nilsdeppe merged commit 413cb57 into sxs-collaboration:develop Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants