Bns input file cleanups #5497
Merged
Bns input file cleanups #5497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
force-pushed
the
bns_input_file_cleanups
branch
from
3203402 to
c0d2586
Compare
knelli2
reviewed
Sep 26, 2023
Comment on lines
244
to
310
| LMax: 16 | ||
| LMax: 8 |
There was a problem hiding this comment.
Maybe keep this one? 16 is what is typically used in SpEC and you've disabled the event above
Comment on lines
205
to
211
| - Trigger: | ||
| Slabs: | ||
| EvenlySpaced: | ||
| Interval: 50 | ||
| Offset: 0 | ||
| Events: | ||
| # BondiSachsInterpolation is for observing GW data. However, the |
There was a problem hiding this comment.
This will technically still trigger even though there are zero events to run. Consider commenting out the trigger as well?
This matches what Nils Deppe has been using for BNS mergers with curved meshes.
nilsdeppe
force-pushed
the
bns_input_file_cleanups
branch
from
c0d2586 to
135ba54
Compare
|
Rebased, made the suggested changes, and switch to using |
nilsvu
approved these changes
Sep 29, 2023
knelli2
approved these changes
Sep 29, 2023
|
CI failures are unrelated timeouts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
FixConservativesAndComputePrims. most of our BNS failures have been happening in this routine.Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments