Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compiling temperature init with analytic solutions #5508

Merged
merged 3 commits into from
Oct 1, 2023
Merged

Fix compiling temperature init with analytic solutions #5508

merged 3 commits into from
Oct 1, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Sep 28, 2023

Proposed changes

We should test these on CI...

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu requested review from ermost and a team September 28, 2023 06:14
@nilsvu nilsvu added the bugfix label Sep 28, 2023
@isaaclegred
Copy link
Contributor

The good news is that with runtime initial data this will be tested automatically

@ermost
Copy link
Contributor

ermost commented Sep 28, 2023

Thanks for fixing this!

nilsdeppe
nilsdeppe previously approved these changes Sep 29, 2023
View reviewed changes
@nilsdeppe
Copy link
Member

This doesn't build...

@nilsvu
Fix compiling temperature init with analytic solutions
7aa56bf 
Without this fix the ValenciaDivClean executables with
analytic solutions don't compile (apparently we don't test
them on CI).
@nilsvu
Fix a compiler error in GH+CCE/M executables
cdddebc 
Still don't compile.
@nilsvu
Copy link
Member Author

nilsvu commented Sep 29, 2023

Squashed in a fix in RelativisticEuler/SmoothFlow

@nilsvu nilsvu requested a review from nilsdeppe October 1, 2023 16:00
@nilsdeppe nilsdeppe merged commit 3c96431 into sxs-collaboration:develop Oct 1, 2023
@nilsvu nilsvu deleted the fix_execs branch October 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ermost ermost ermost approved these changes

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nilsvu @isaaclegred @ermost @nilsdeppe