Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bug in Grmhd BCGhostData #5524

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Fix Bug in Grmhd BCGhostData #5524

merged 1 commit into from
Oct 3, 2023

Conversation

isaaclegred
Copy link
Contributor

Proposed changes

Currently the GrMhd version of BoundaryConditionGhostData hasn't been updated to be compatible with temperature reconstruction. This PR fixes it.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@isaaclegred isaaclegred added small Only changes a few lines of code, does a rename or is otherwise quick to review bugfix labels Oct 2, 2023
@isaaclegred
Copy link
Contributor Author

@nilsdeppe @ermost this should be fairly painless to review I think!

@nilsdeppe nilsdeppe added the priority critical for progress label Oct 3, 2023
@nilsdeppe nilsdeppe merged commit def41a5 into sxs-collaboration:develop Oct 3, 2023
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees
No one assigned
Labels
bugfix priority critical for progress small Only changes a few lines of code, does a rename or is otherwise quick to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isaaclegred @nilsdeppe