Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linking of ExternalIO on Wheeler #5530

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 3, 2023

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu nilsvu added priority critical for progress bugfix build system CMake build system labels Oct 3, 2023
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this branch I was able to configure on Wheeler in a new build directory without error with

knelli@wheeler:~/spectre$ mkdir build_test
knelli@wheeler:~/spectre$ cd build_test/
knelli@wheeler:~/spectre/build_test$ module purge
knelli@wheeler:~/spectre/build_test$ source ../support/Environments/wheeler_gcc.sh 
knelli@wheeler:~/spectre/build_test$ spectre_load_modules 
knelli@wheeler:~/spectre/build_test$ spectre_run_cmake

@yoonso0-0 @jyoo1042 Can you confirm this?

@yoonso0-0
Copy link
Contributor

Worked

@jyoo1042
Copy link
Contributor

jyoo1042 commented Oct 3, 2023

fixed the issue

@knelli2 knelli2 enabled auto-merge October 3, 2023 18:13
@knelli2 knelli2 merged commit 374deb9 into sxs-collaboration:develop Oct 3, 2023
20 of 21 checks passed
@nilsvu nilsvu deleted the fix_external_io branch October 4, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix build system CMake build system priority critical for progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants