Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expiration_after method to FunctionOfTime #5544

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Oct 6, 2023

Necessary for deterministically coupling the evolution step size to the control system updates.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

src/Domain/FunctionsOfTime/FunctionOfTime.hpp Outdated Show resolved Hide resolved
src/Domain/FunctionsOfTime/FunctionOfTime.hpp Outdated Show resolved Hide resolved
Necessary for deterministically coupling the evolution step size to
the control system updates.
Copy link
Member Author

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squashed in the doc change.

src/Domain/FunctionsOfTime/FunctionOfTime.hpp Outdated Show resolved Hide resolved
src/Domain/FunctionsOfTime/FunctionOfTime.hpp Outdated Show resolved Hide resolved
@knelli2 knelli2 enabled auto-merge October 11, 2023 22:41
@knelli2 knelli2 merged commit e586a65 into sxs-collaboration:develop Oct 12, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants