Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix status CLI if user directory can't be read #5551

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Oct 9, 2023

Proposed changes

Some early returns were missing if job list is empty after dropping some jobs. Fixes #5549.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Some early returns were missing if job list is empty after
dropping some jobs.
@nilsvu nilsvu requested a review from knelli2 October 9, 2023 04:40
@nilsvu nilsvu added bugfix cli/pybindings Command line interface & Python bindings labels Oct 9, 2023
@nilsvu nilsvu merged commit bd2aaf5 into sxs-collaboration:develop Oct 9, 2023
20 of 22 checks passed
@nilsvu nilsvu deleted the fix_py_status branch October 9, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully exit Status CLI if permission denied error
2 participants