Enable p-refinement for ScalarWave executables #5573
Conversation
| ::ScalarWave::Tags::ConstraintGamma2>, | ||
| evolution::dg::Initialization::ProjectMortars<EvolutionMetavars>, | ||
| evolution::Actions::ProjectRunEventsAndDenseTriggers, | ||
| ::amr::projectors::DefaultInitialize< |
There was a problem hiding this comment.
Can you move some/all of these to the corresponding projectors? Would be easier if these are handled by the code that adds the tags, so you don't have to worry about them in the metavars.
There was a problem hiding this comment.
I can, but will defer doing so until I implement the h-refinement overloads for the projectors as what is default initialized may change...
There was a problem hiding this comment.
I'm not sure I understand, the way these are handled might change with adding h-refinement, but moving the responsibility to the projectors (which live next to the initializer that adds the tag) already now seems easier than doing so later.
There was a problem hiding this comment.
It is psychological; replacing 5 lines of code with multiple commits adding dozens of lines now seems a waste of my time. On the other hand, I can easily make the changes across multiple PRs when implementing h-refinement.
There was a problem hiding this comment.
We have to add these to every executable though when we add support for AMR. If you prefer that fine with me, just checking.
There was a problem hiding this comment.
Merging now, this can be done ina follow-up as well when adding AMR to more executables
Currently only works for global time stepping. The 2D and 3D input files do not do any AMR, look at the 1D examples to actually perform AMR.
kidder
force-pushed
the
sw_p_refine_gts
branch
from
5bead83 to
fd25de7
Compare
Proposed changes
Enable p-refinement for ScalarWave executables.
Currently only works for global time-stepping.
Only the example input files for 1D actually do AMR during the evolution. See them if you want to use AMR in 2D or 3D.
Upgrade instructions
ScalarWave input files need to have additional options, as well as now using global time-steppers instead of local time-steppers. (See the diff of
tests/InputFiles/ScalarWave/PlaneWave1D.yaml)Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments