Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute scalar sources for Klein-Gordon Cce hypersurface equations #5784

Merged

Conversation

Sizheng-Ma
Copy link
Contributor

Proposed changes

In scalar-tensor theory, Cce hypersurface equations get additional source terms contributed by the stress-energy tensor of the scalar field. This PR adds and computes the corresponding tags.

The first commit adds a prefix tag Tags::KleinGordonSource for the source terms of the evolved variables (Tags::BondiBeta, Tags::BondiQ, Tags::BondiU,Tags::BondiW and Tags::BondiH). The second commit initializes the data storage in the databox for Tags::KleinGordonSource, as well as other tags that are required for later calculation. To compute the source terms, two quantities Tags::Dy<Tags::KleinGordonPsi> and Spectral::Swsh::Tags::Derivative<Tags::KleinGordonPsi, Spectral::Swsh::Tags::Eth> are needed. The third commit adds an action to compute their values. Finally, the last commit adds mutators Cce::ComputeKleinGordonSource to calculate the source terms.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@Sizheng-Ma Sizheng-Ma force-pushed the compute_sources_for_kg_cce branch 4 times, most recently from 5f08170 to 6a80ba0 Compare March 2, 2024 22:21
@Sizheng-Ma Sizheng-Ma force-pushed the compute_sources_for_kg_cce branch from 6a80ba0 to 81989df Compare March 3, 2024 04:14
@Sizheng-Ma Sizheng-Ma force-pushed the compute_sources_for_kg_cce branch from 81989df to 62d652d Compare March 3, 2024 16:42
Copy link
Member

@wthrowe wthrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the internals of the CCE code well, but looks fine.

@wthrowe wthrowe merged commit 4b216e4 into sxs-collaboration:develop Mar 8, 2024
21 of 22 checks passed
@Sizheng-Ma Sizheng-Ma deleted the compute_sources_for_kg_cce branch March 9, 2024 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants