Compute scalar sources for Klein-Gordon Cce hypersurface equations #5784
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In scalar-tensor theory, Cce hypersurface equations get additional source terms contributed by the stress-energy tensor of the scalar field. This PR adds and computes the corresponding tags.
The first commit adds a prefix tag
Tags::KleinGordonSource
for the source terms of the evolved variables (Tags::BondiBeta
,Tags::BondiQ
,Tags::BondiU
,Tags::BondiW
andTags::BondiH
). The second commit initializes the data storage in the databox forTags::KleinGordonSource
, as well as other tags that are required for later calculation. To compute the source terms, two quantitiesTags::Dy<Tags::KleinGordonPsi>
andSpectral::Swsh::Tags::Derivative<Tags::KleinGordonPsi, Spectral::Swsh::Tags::Eth>
are needed. The third commit adds an action to compute their values. Finally, the last commit adds mutatorsCce::ComputeKleinGordonSource
to calculate the source terms.Upgrade instructions
Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments