Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute scalar self-force in UpdateAcceleration #5793

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

nikwit
Copy link
Contributor

@nikwit nikwit commented Feb 22, 2024

Changes the UpdateAcceleration mutator to compute the acceleration due to the scalar self-force.

depends on #5787

@nikwit nikwit added the dependent Needs a different PR to be merged in first label Feb 22, 2024
@nikwit nikwit force-pushed the self-force-update-acc branch from 0e1cd1b to 2beef6e Compare February 28, 2024 17:38
@nikwit nikwit force-pushed the self-force-update-acc branch from 2beef6e to 10daec7 Compare March 8, 2024 18:44
@nikwit nikwit removed the dependent Needs a different PR to be merged in first label Mar 8, 2024
@nikwit nikwit force-pushed the self-force-update-acc branch 2 times, most recently from 5d1e524 to 018a5a0 Compare March 8, 2024 19:27
knelli2
knelli2 previously approved these changes Mar 12, 2024
Copy link
Contributor

@knelli2 knelli2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one optional thing if you want

Comment on lines 26 to 27
particle_velocity.get(i) * inverse_metric.get(0, 0)) *
get(dt_psi_monopole) * particle_charge / particle_mass / u0_squared;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[optional] Factor out the computation of particle_charge / particle_mass / u0_squared so it isn't recomputed. (useful also for the loop below)

@nikwit
Copy link
Contributor Author

nikwit commented Mar 12, 2024

Done, thanks for the review!

@knelli2 knelli2 enabled auto-merge March 12, 2024 21:39
@knelli2 knelli2 added the auto-merge GitHub's auto-merge has been enabled for this PR. label Mar 12, 2024
@knelli2 knelli2 merged commit eb3f302 into sxs-collaboration:develop Mar 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge GitHub's auto-merge has been enabled for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants