Add Evolution and Past Term to BinaryWithGravitationalWaves #5901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaorebelo-megum
force-pushed
the
binary_gw_evolution
branch
from
cfb2f87 to
5304fd7
Compare
joaorebelo-megum
force-pushed
the
binary_gw_evolution
branch
2 times, most recently
from
e0ab34d to
a225f3a
Compare
Create the initial base files for WavyBBH class with no explicit computations, just the bare minimum to get used to coding. Compilation is successful. Run SolveXcts with .yaml file gives error.
Various comments in the PR were addressed.
Various comments in the PR were addressed.
First std::move used on constructer for mesh and inv_jacobian was taken out
joaorebelo-megum
force-pushed
the
binary_gw_evolution
branch
from
effeba2 to
09eefb0
Compare
Added the past terms to the conformal metric.
The python methods to solve the retarded time equation at each point were added. The evolution is not done but is being read from a file. The interpolation plus root finder doesn't give enough precision to pass the test. It is commented out.
Dependence on dat file was taken out
Changed std::bind to lambda functions in ode integration.
Static_cast for interpolation. const references in constructer
Now using the cardinal_cubic_hermite.
And others.
The PastEvolution file was changed to output a csv.
joaorebelo-megum
force-pushed
the
binary_gw_evolution
branch
from
09eefb0 to
cf9c830
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The calculations for needed for the past term of the conformal metric are added.
The Past Evolution is done with an Hamiltonian Formalism in Post-Newtonian approximation.
The interpolation of the positions/momentum of the binary is done with cubic hermite interpolation.
The Retarded Times are given by a numerical root finding method (toms748).
The Past Term is added to the radiative term.
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments
The first and second commit are from PR #5799.
The Integral Term will be added in a later PR (set to zero at the moment).