Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to read in numerical initial data for CurvedScalarWave #6154

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

guilara
Copy link
Contributor

@guilara guilara commented Jul 16, 2024

Proposed changes

Add actions to read in numerical initial data for the CurvedScalarWave system. These data can be obtained, for instance, from an elliptic solve of the Poisson equation.

To be combined in a future PR with reading in numeric data for the metric variables in the ScalarTensor system.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@guilara guilara added this to the ScalarTensor evolution milestone Jul 16, 2024
@guilara guilara force-pushed the PRs-ReadIDCsw branch 3 times, most recently from 4316e11 to 83fec08 Compare July 29, 2024 12:42
@guilara guilara marked this pull request as ready for review July 29, 2024 12:45
@guilara guilara changed the title Allow to read numerical initial data for CurvedScalarWave Allow to read in numerical initial data for CurvedScalarWave Jul 29, 2024
@knelli2 knelli2 requested a review from nilsvu August 21, 2024 17:03
@guilara
Copy link
Contributor Author

guilara commented Dec 14, 2024

@nikwit I just rebased this. But haven't figured out yet how to include it in the CSW executable. I've only used it for the ScalarTensor system (which mimics the Gh system) and where we use the evolution::initial_data::InitialData class (e.g.

).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant