Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All cocal implementation #6344

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

MaiLi-UIUC
Copy link

Proposed changes

This pull request introduces a COCAL initial data reader into SpECTRE, enabling simulations to use initial data generated by the COCAL code.

Upgrade instructions

No upgrade instructions are necessary.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

The procedure to use the COCAL initial data is:

  1. Run export COCAL_ROOT=/Path/To/Main/SpECTRE/Directory/src/PointwiseFunctions/AnalyticData/GrMhd/COCAL_reader
  2. Build SpECTRE and executable as always.
  3. In the Input file, specify these three options:
    InitialData:
    CocalInitialData:
    DataDirectory: "/Path/To/The/Cocal/Initial/Data"
    IdType: (Choose from "Ir", "Co" and "Sp")
    ElectronFraction:
  4. In the submit.sh file, change ++ppn to +ppn and submit.

@MaiLi-UIUC MaiLi-UIUC changed the title All cocal implemention All cocal implementation Oct 19, 2024
@kidder kidder marked this pull request as draft October 29, 2024 17:43
@MaiLi-UIUC MaiLi-UIUC marked this pull request as ready for review November 12, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant