Fix FPEs occurring when density is zero in MC #6383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
previously approved these changes
Nov 21, 2024
Comment on lines
23
to
27
| void test_flat_space_time_step(const bool skip) { | ||
| CHECK(true); | ||
| // This test FPEs because the ghost zone handling is broken. | ||
| if (skip) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Maybe just
void test_flat_space_time_step() {since presumably we won't need to skip this test anymore? :D
There was a problem hiding this comment.
Done (rebased and merged)
ffoucart
force-pushed
the
FixFPEZeroDensityGZ
branch
from
8d28e53 to
384088c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make two fixes to unsafe part of the MC code when a zero density is provided to the neutrino interaction table; this allows us to restore 1/2 failing MC tests.
Upgrade instructions
None
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments