Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support spherical shell blocks, create Sphere domain #6392

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Dec 2, 2024

Proposed changes

Add an enum to Block that indicates whether the block represents a Cube or a SphericalShell. Cubes can only have one block neighbor per dimension, whereas spherical shells can have multiple block neighbors (another shell, or 4 wedges in 2D, or 6 wedges in 3D).
Also adds the code to connect element neighbors across spherical and cubed shells, to create the Ylm meshes, and to create a Sphere domain with spherical shells.
Only the spherical-to-cartesian coordinate map is missing to create spherical shells in ExportCoordinates3D. The coordinate maps are in #5588, but need to be adjusted a bit because we use the spherical coordinates directly as logical coordinates, so we don't need the maps from [-1, 1] to angles.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@nilsvu
Copy link
Member Author

nilsvu commented Dec 2, 2024

@kidder this is to share this code with you. I have cleaned up the first 3 commits. The others need some more cleanup. I can do that and add some more tests. The last commit e4c2593 will be superseded by your #6389 .

@nilsvu nilsvu force-pushed the spherical_shell_blocks branch from e4c2593 to a9e4305 Compare December 9, 2024 16:58
@nilsvu nilsvu force-pushed the spherical_shell_blocks branch from a9e4305 to 6b915a0 Compare December 14, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant