Fix shape map loaded from file #6395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knelli2
requested changes
Dec 5, 2024
Comment on lines
262
to
265
| std::pair<std::array<DataVector, 3>, std::array<DataVector, 4>> | ||
| initial_shape_and_size_funcs( |
There was a problem hiding this comment.
Can't reach with GitHub comments, but we should note somewhere in some help text that with this change, the deformed radius will be exactly what is in the YlmsFromFile, and not what is set for the inner/outer radius in the input file.
The size of the domain didn't match the Strahlkorper in the file because the loaded l=0, m=0 coefficient was interpreted as a deformation/scale. Fixed by subtracting the size of the original sphere.
nilsvu
force-pushed
the
shape_from_file
branch
from
de49312 to
1274f50
Compare
|
done |
knelli2
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The size of the domain didn't match the Strahlkorper in the file because the loaded l=0, m=0 coefficient was interpreted as a deformation/scale. Fixed by subtracting the size of the original sphere.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments