Allow Singletons to use ExecutePhaseChange
#6401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikwit
force-pushed
the
singleton-change-phase
branch
from
bdd8fdd to
6944ebe
Compare
knelli2
requested changes
Dec 11, 2024
Comment on lines
7
to
8
| # note that this is a vector of pairs, so has the peculiar '- -' for the | ||
| # elements |
There was a problem hiding this comment.
This comment is outdated from an old syntax for PhaseChangeAndTriggers.
Comment on lines
+76
to
+79
| if constexpr (std::is_same_v<typename SenderComponent::chare_type, | ||
| Parallel::Algorithms::Singleton>) { | ||
| Parallel::local(Parallel::get_parallel_component<SenderComponent>(cache)) | ||
| ->contribute(static_cast<int>(reduction_data.size()), |
There was a problem hiding this comment.
Note that technically this could have been put into the other contribute_to_phase_change_reduction function that already uses Parallel::local, but then every phase change would have to be updated to call the other function for both arrays and singletons. I think this current way is cleaner.
nikwit
force-pushed
the
singleton-change-phase
branch
from
6944ebe to
093595a
Compare
knelli2
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR allows singletons to contribute to reduction data by calling
ExecutePhaseChange. I needed this to checkpoint the worldtube singleton.I duplicate the algorithm unit test for this action it to show that it works with singletons now as well.