Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mc optically thick sphere #6402

Closed
wants to merge 6 commits into from
Closed

Mc optically thick sphere #6402

wants to merge 6 commits into from

Conversation

ffoucart
Copy link
Contributor

Proposed changes

Provide a first initial condition for the standalone MC code -- a uniform sphere with different fluid properties inside and outside the sphere.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@ffoucart ffoucart marked this pull request as draft December 10, 2024 20:23
@ffoucart
Copy link
Contributor Author

ffoucart commented Dec 10, 2024

Depends on #6355 (the first five commits are from that PR).
@nilsdeppe @kidder : This is the next step for the MC executable -- initial data that does not directly rely on the GrMhd solutions.

@ffoucart ffoucart closed this Dec 10, 2024
@ffoucart ffoucart deleted the MCOpticallyThickSphereID branch December 10, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant