Mc optically thick sphere #6403
Conversation
|
Depends on #6355 (first five commits are from that PR) |
ffoucart
force-pushed
the
MCOpticallyThickSphereID
branch
from
7d7ae5f to
9bbe256
Compare
|
Updated so that first two commits match #6355 and third commit is the new work. |
ffoucart
force-pushed
the
MCOpticallyThickSphereID
branch
from
9bbe256 to
dad3fdf
Compare
ffoucart
force-pushed
the
MCOpticallyThickSphereID
branch
from
dad3fdf to
26b2fe5
Compare
| @@ -131,12 +137,20 @@ struct EvolutionMetavars { | |||
| }; | |||
|
|
|||
| using observe_fields = | |||
| tmpl::list<domain::Tags::Coordinates<volume_dim, Frame::Grid>, | |||
| domain::Tags::Coordinates<volume_dim, Frame::Inertial>>; | |||
| tmpl::list<evolution::dg::subcell::Tags::ObserverCoordinatesCompute< | |||
There was a problem hiding this comment.
you should make the tags of ObserverCoordinates conditional on use_dg_subcell like is done in EvolveValenciaDivClean
| tmpl::list<::Events::Tags::ObserverMeshCompute<volume_dim>, | ||
| ::Events::Tags::ObserverDetInvJacobianCompute< | ||
| Frame::ElementLogical, Frame::Inertial>>; | ||
| tmpl::list<evolution::dg::subcell::Tags::ObserverMeshCompute<volume_dim>, |
There was a problem hiding this comment.
again conditional on use_dg_subcell
| @@ -25,6 +25,7 @@ void cell_light_crossing_time( | |||
| inertial_coordinates.get(1)[step[1]] - inertial_coordinates.get(1)[0], | |||
| inertial_coordinates.get(2)[step[2]] - inertial_coordinates.get(2)[0]}; | |||
|
|
|||
| get(*cell_light_crossing_time) = DataVector(n_pts,0.0); | |||
There was a problem hiding this comment.
just need number of points, don't have to initialize to a value as it is overwritten
| @@ -381,6 +397,26 @@ struct ReceiveDataForMcCommunication { | |||
| } else { | |||
| const size_t n_packets = received_data_packets.value().size(); | |||
| for (size_t p = 0; p < n_packets; p++) { | |||
| // Find closest grid point to received packet at current | |||
| // time, using extents for live points only. | |||
| Packet& packet = received_data_packets.value()[p]; | |||
There was a problem hiding this comment.
I think this can be simplified a lot as the computation is done in ElementLogicalCoordinates.
In each dimension there are n = extents[d] subcells of uniform size and the grid points are at cell centers. Therefore you just need to determine which cell they are in which is given by cell_index[d] = std::floor(packet.coordinate[d] + 1.0)/(2*n) and then index_of_closest_grid_point = collapsed_index(cell_index, extents). I guess you need to add a special case if the packet coordinate is 1.0
|
|
||
| #include "Evolution/Particles/MonteCarlo/MonteCarloOptions.hpp" | ||
|
|
||
| #include <cmath> |
|
|
||
| DataVector get_mask(const tnsr::I<DataVector, 3>& x, | ||
| const double radius_bound) { | ||
| const DataVector radius = sqrt((x.get(0) * x.get(0)) + (x.get(1) * x.get(1)) + |
There was a problem hiding this comment.
here too use Euclidean magnitude function
| @@ -65,4 +66,22 @@ struct InteractionRatesTable : db::SimpleTag { | |||
| } | |||
| }; | |||
|
|
|||
| template <size_t NeutrinoSpecies> | |||
| struct MonteCarloOptions : db::SimpleTag { | |||
| using type = std::unique_ptr< | |||
There was a problem hiding this comment.
I don't think this needs to be a unique_ptr, but just the class
| const std::vector<Packet>& packets, const Scalar<DataVector>& lapse, | ||
| const Scalar<DataVector>& sqrt_determinant_spatial_metric, | ||
| const Mesh<3>& mesh, | ||
| const Scalar<DataVector>& det_inv_jacobian_logical_to_inertial) { |
There was a problem hiding this comment.
move the function definition to the cpp file
| Scalar<DataVector> cell_inertial_three_volume(lapse); | ||
| cell_inertial_coordinate_three_volume_finite_difference( | ||
| &cell_inertial_three_volume, mesh, det_jacobian_logical_to_inertial); | ||
| get(*fluid_frame_energy_density) = 0.0 * get(lapse); |
There was a problem hiding this comment.
just use *fluid_frame_energy_density = make_with_value<Scalar<DataVector>>(lapse, 0.0);
| using MortarData = | ||
| typename Particles::MonteCarlo::Tags::MortarDataTag<dim>::type; | ||
| MortarData mortar_data; | ||
| const Element<dim>& element = db::get<::domain::Tags::Element<dim>>(box); |
There was a problem hiding this comment.
Do you need to do this initialization? please check
Proposed changes
Add initial conditions for a homogeneous sphere (fluid variables only determined by whether we are inside or outside the sphere)
Upgrade instructions
None
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.