Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop modifications to libsharp #6407

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Dec 11, 2024

I do not believe we are allowed to integrate modified GPL code into
the SpECTRE source. There may be an exception if the modified code
could still be used separately, but the changes we made to libsharp
did not allow that since we replaced its build system with SpECTRE's.

This replaces the contents of the external/libsharp directory with the
unmodified source, and builds it as an external project.

Note to reviewers: in the last commit, the non-libsharp files modified are docs/Installation/Installation.md and external/CMakeLists.txt.

Proposed changes

Upgrade instructions

GNU Make is now a required dependency. Using Ninja to build SpECTRE will continue to work, but it will internally use make to build the bundled libsharp libraries.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

I do not believe we are allowed to integrate modified GPL code into
the SpECTRE source.  There may be an exception if the modified code
could still be used separately, but the changes we made to libsharp
did not allow that since we replaced its build system with SpECTRE's.

This replaces the contents of the external/libsharp directory with the
unmodified source, and builds it as an external project.
Copy link
Member

@nilsdeppe nilsdeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for doing this!!

@nilsdeppe nilsdeppe merged commit 49286a3 into sxs-collaboration:develop Jan 8, 2025
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants