Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check FoTs are ready in ObserveConstantsPerElement #6414

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Check FoTs are ready in ObserveConstantsPerElement #6414

merged 2 commits into from
Dec 16, 2024

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Dec 13, 2024

Not guaranteed for events that do not use the evolved variables.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe
Make FoT algorithm_callback handle nodegroups
ce959e2 
Instead of every caller embedding the nodegroup check logic, move it
inside the function.

Removed the call from the Interpolate event as FoTs are guaranteed to
be ready there.
@wthrowe
Check FoTs are ready in ObserveConstantsPerElement
dacb94c 
Not guaranteed for events that do not use the evolved variables.
@nilsdeppe nilsdeppe merged commit 970e70d into sxs-collaboration:develop Dec 16, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knelli2 knelli2 knelli2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wthrowe @knelli2 @nilsdeppe