Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use git-clang-format corresponding to clang-format #6415

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Dec 13, 2024

Might not be compatible with git-clang-format version.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe wthrowe force-pushed the git-clang-format_version branch from 981e89e to 5070cb0 Compare January 13, 2025 19:55
@wthrowe wthrowe changed the title Don't force particular clang-format binary Use git-clang-format corresponding to clang-format Jan 13, 2025
@nilsvu nilsvu merged commit 3ecc86a into sxs-collaboration:develop Jan 14, 2025
22 of 23 checks passed
@knelli2 knelli2 added the build system CMake build system label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system CMake build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants