Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CellCenteredFlux to work for mixed systems #6418

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kidder
Copy link
Member

@kidder kidder commented Dec 17, 2024

Previously CellCenteredFlux assumed that the flux_variables were the same as the evolved variables.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

Previously CellCenteredFlux assumed that the flux_variables were
the same as the evolved variables.
@kidder kidder requested a review from nilsdeppe December 17, 2024 19:13
@nilsdeppe nilsdeppe merged commit 4ba6a0f into sxs-collaboration:develop Dec 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants