Add test for partial_derivatives with spherical harmonics #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsdeppe
requested changes
Dec 19, 2024
| Variables< | ||
| db::wrap_tags_in<Tags::deriv, GradientTags, tmpl::size_t<3>, Frame::Grid>> | ||
| expected_du(number_of_grid_points); | ||
| Approx local_approx = Approx::custom().epsilon(1e-9).scale(1.0); |
There was a problem hiding this comment.
Do you need to force the scale to 1 instead of just a relative error? Also, 1e-9 seems sort of large? Do you know why it's that large?
There was a problem hiding this comment.
- yes, because some of the derivs are zero.
- because I copied it from the generic 3d test. I've updated it to 1e-13.
kidder
force-pushed
the
spherical_derivative_test
branch
from
1da6a41 to
f858d41
Compare
nilsdeppe
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add test for partial_derivatives with spherical harmonics
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments