-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check SpEC version when importing #6467
base: develop
Are you sure you want to change the base?
Conversation
Will this be superceded by #6471? @nilsvu @nilsdeppe |
8049ede
to
20b7068
Compare
no I don't think so. rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI very unhappy
20b7068
to
dd2e8f3
Compare
@nilsdeppe Did you want to take a look at this? Check that it works on mbot? |
Yes, please don't merge this because it'll break mbot and I don't have time
to upgrade spec right now.
…On Tue, Feb 11, 2025, 14:09 Kyle Nelli ***@***.***> wrote:
@nilsdeppe <https://github.com/nilsdeppe> Did you want to take a look at
this? Check that it works on mbot?
—
Reply to this email directly, view it on GitHub
<#6467 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADHHPFWE2F4PO5XX5EYQRHL2PJDF3AVCNFSM6AAAAABWI72TAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNJRHAZDGMRWGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
It shouldn't break mbot, only the unit tests that try to import spec will fail (ecc control and initial orbital params). |
dd2e8f3
to
a256421
Compare
a256421
to
7e4a8d3
Compare
Proposed changes
Check the SpEC version when import Python modules to make sure it's compatible (of course the real solution is to port SpEC modules into SpECTRE when we need them or factor the code into a separate repository, but that requires some work and comes with a maintenance burden keeping the two codes in sync).
Upgrade instructions
To use eccentricity control, make sure you're pointing to a recent enough SpEC version (Aug 2024) and update your Python environment with
pip install -r Support/Python/requirements.txt
to pick up the newgit
dependency (if running on CaltechHPC you don't have to do anything).Code review checklist
make doc
to generate the documentation locally intoBUILD_DIR/docs/html
.Then open
index.html
.code review guide.
bugfix
ornew feature
if appropriate.Further comments