Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Skew control system to BBH #6487

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

knelli2
Copy link
Contributor

@knelli2 knelli2 commented Feb 19, 2025

Proposed changes

Part of #4603.

Depends on (but doesn't include) #6482 .

Upgrade instructions

Any input file for the BBH executable must now also have a Skew: block under the ControlSystems: group with all the same options as the other control systems.

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@knelli2 knelli2 added the dependent Needs a different PR to be merged in first label Feb 19, 2025
@knelli2 knelli2 added this to the BBH larger q & higher spins milestone Feb 19, 2025
@knelli2 knelli2 mentioned this pull request Feb 21, 2025
3 tasks
@knelli2
Copy link
Contributor Author

knelli2 commented Feb 21, 2025

Still dependent, but now on #6493 (not included)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent Needs a different PR to be merged in first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant