Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BBH pipeline: set time bounds in ecc control #6490

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

nilsvu
Copy link
Member

@nilsvu nilsvu commented Feb 20, 2025

Proposed changes

Run an ecc control iteration for 2-3 orbits and determine tmin for the eccentricity fit dynamically.

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

This should be good enough for now.
We can set this more dynamically in the future.
@nilsvu nilsvu added the cli/pybindings Command line interface & Python bindings label Feb 20, 2025
@nilsvu nilsvu added this to the BBH Pipeline Automation milestone Feb 20, 2025
@nilsvu nilsvu requested a review from knelli2 February 20, 2025 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli/pybindings Command line interface & Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants