Allow prolongation/restriction for shape FoT from vol file #6491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilsvu
previously approved these changes
Feb 20, 2025
| const_cast<DataVector&>(gsl::at(shape_funcs, i)).data(), // NOLINT | ||
| gsl::at(shape_funcs, i).size()); | ||
| // The centers and radii of the following don't matter. Only their l_max | ||
| // and their coefficients |
There was a problem hiding this comment.
Can you just create a YlmSpherepack object without the unused radius?
There was a problem hiding this comment.
Yeah, I had just copied other code. This new way is much cleaner.
knelli2
force-pushed
the
shape_fot_vol_restriction
branch
from
b45a47b to
fb550ef
Compare
nilsvu
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Upgrade instructions
If you are reading the shape function of time from a volume H5 file, add
LMax: Autoto the options.Autohere will choose the LMax from the volume H5 file, or if a number is specified, that number will be the new LMax and a prolongation/restriction of the volume H5 shape FoT will happen.Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixornew featureif appropriate.Further comments