Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged back changes made in AudioKit #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

megastep
Copy link

Hi there,

These are mostly some changes I've done while integrating the current version of EZAudio in the AudioKit project. Good job on improving the performance of these plots, by the way!

These are rather minor things compared to what we were using before, but if you don't mind merging that back then it will make it easier to keep AudioKit and EZAudio in sync from now on.

  • Use const float * buffers where appropriate to indicate the original data is not being mutated and avoid some nasty casts on our side.
  • Extended IBInspectable properties and marked classes with IB_DESIGNABLE
  • Rewrote the RMS method using the Accelerate framework, since you now link with it it shouldn't be an issue and may even improve performance a bit further.

@syedhali
Copy link
Owner

Sweet, really appreciate this @megastep. I'll take a quick look and get these changes in later today!

…ith YES twice in a row would effectively disable the display link and prevent updates.
@megastep
Copy link
Author

I just found a bug that surfaced in AudioKit and included a fix for it, by the way. :)

@JanX2
Copy link

JanX2 commented Mar 3, 2016

Is there a reason, why this hasn’t been merged? LGTM. :)

@megastep
Copy link
Author

megastep commented Mar 3, 2016

Well it's been a while so I hope this is still relevant!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants