EZMicrophone fixes: memory leaks and crash after de-allocation

EZAudio/EZAudioFile.m

@@ -149,7 +149,7 @@ -(void)_configureAudioFile {
     _floatBuffers[i] = (float*)malloc(outputBufferSize);
   }
 
-    [EZAudio printASBD:_fileFormat];
+//    [EZAudio printASBD:_fileFormat];
 
   // There's no waveform data yet
   _waveformData = NULL;

EZAudio/EZAudioPlayer.m

@@ -245,6 +245,13 @@ -(void)stop {
     [_output stopPlayback];
     [_audioFile seekToFrame:0];
     _eof = NO;
+
+      if( self.audioPlayerDelegate ){
+          if( [self.audioPlayerDelegate respondsToSelector:@selector(audioPlayer:didPausePlaybackOnAudioFile:)] ){
+              // Notify the delegate we're pausing playback
+              [self.audioPlayerDelegate audioPlayer:self didPausePlaybackOnAudioFile:_audioFile];
+          }
+      }
   }
 }
 
@@ -286,10 +293,19 @@ -(void)             output:(EZOutput *)output
                    audioBufferList:audioBufferList
                         bufferSize:&bufferSize
                                eof:&_eof];
-        if( _eof && self.shouldLoop )
-        {
-            [self seekToFrame:0];
+        if(_eof ){
+
+            //Notifies delegate about _eof
+            if(self.audioPlayerDelegate)
+                if ([self.audioPlayerDelegate respondsToSelector:@selector(audioPlayer:reachedEndOfAudioFile:)])
+                        [self.audioPlayerDelegate audioPlayer:self reachedEndOfAudioFile:self.audioFile];
+
+            //loops the playback if needed
+            if(self.shouldLoop )
+                [self seekToFrame:0];
         }
+
+
     }
 }
 

EZAudio/EZAudioPlot.m

@@ -41,7 +41,7 @@ @interface EZAudioPlot () {
 @end
 
 @implementation EZAudioPlot
-@synthesize backgroundColor = _backgroundColor;
+//@synthesize backgroundColor = _backgroundColor;
 @synthesize color           = _color;
 @synthesize gain            = _gain;
 @synthesize plotType        = _plotType;
@@ -96,8 +96,9 @@ -(void)initPlot {
 
 #pragma mark - Setters
 -(void)setBackgroundColor:(id)backgroundColor {
-  _backgroundColor = backgroundColor;
-  [self _refreshDisplay];
+
+    [super setBackgroundColor:backgroundColor];
+    [self _refreshDisplay];
 }
 
 -(void)setColor:(id)color {

EZAudio/EZAudioPlotGL.m

@@ -77,7 +77,7 @@ @implementation EZAudioPlotGL
 #elif TARGET_OS_MAC
 @synthesize baseEffect = _baseEffect;
 #endif
-@synthesize backgroundColor  = _backgroundColor;
+//@synthesize backgroundColor  = _backgroundColor;
 @synthesize color            = _color;
 @synthesize gain             = _gain;
 @synthesize plotType         = _plotType;
@@ -137,7 +137,9 @@ -(void)initializeView {
 
 #pragma mark - Setters
 -(void)setBackgroundColor:(id)backgroundColor {
-  _backgroundColor = backgroundColor;
+
+    [super setBackgroundColor:backgroundColor];
+
 #if TARGET_OS_IPHONE
   self.glViewController.backgroundColor = backgroundColor;
 #elif TARGET_OS_MAC

EZAudio/EZMicrophone.m

@@ -596,4 +596,34 @@ -(void)_disableCallbackBufferAllocation {
              operation:"Could not disable audio unit allocating its own buffers"];
 }
 
+#pragma mark De-allocation
+
+-(void) dealloc{
+
+    if(_isConfigured){
+
+        //stops fetching if it it is ongoing
+        if(_isFetching)
+            [self stopFetchingAudio];
+
+        //inputCallback shall be unregistered before de-allocation.
+        // Otherwise BAD_ACCESS within inputCallback happens while attempting to access _microphone through (__bridge EZMicrophone*)inRefCon
+        [EZAudio checkResult:
+                AudioUnitRemoveRenderNotify (microphoneInput, inputCallback, (__bridge void *)self)
+                   operation:"Couldn't unregister input callback"];
+
+        //free microphoneInputBuffer to avoid memory leaks
+        [EZAudio freeBufferList:microphoneInputBuffer];
+
+        //free float buffers allocated in _configureFloatConverterWithFrameSize
+        for ( int i=0; i<streamFormat.mChannelsPerFrame; i++ )
+            free(floatBuffers[i]);
+        free(floatBuffers);
+
+        //dicsonnects from delegate
+        self.microphoneDelegate=nil;
+
+    }
+}
+
 @end

EZAudio/EZPlot.h

@@ -64,7 +64,7 @@ typedef NS_ENUM(NSInteger,EZPlotType){
 /**
  The default background color of the plot. For iOS the color is specified as a UIColor while for OSX the color is an NSColor. The default value on both platforms is black.
  */
-@property (nonatomic,strong) id backgroundColor;
+//@property (nonatomic,copy) id backgroundColor;
 
 /**
  The default color of the plot's data (i.e. waveform, y-axis values). For iOS the color is specified as a UIColor while for OSX the color is an NSColor. The default value on both platforms is red.