Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ofac implementation #96

Merged
merged 30 commits into from
Sep 11, 2023
Merged

feat: ofac implementation #96

merged 30 commits into from
Sep 11, 2023

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Aug 4, 2023 •
edited
Loading

Description

Related Issue Or Context

Closes: #38

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@wainola wainola marked this pull request as ready for review August 6, 2023 22:25
@wainola wainola mentioned this pull request Aug 6, 2023
Closed
9 tasks
mpetrun5
mpetrun5 requested changes Aug 7, 2023
View reviewed changes
prisma/schema.prisma Outdated Show resolved Hide resolved
mpetrun5
mpetrun5 requested changes Aug 10, 2023
View reviewed changes
src/indexer/repository/transfer.ts Outdated Show resolved Hide resolved
prisma/schema.prisma Outdated Show resolved Hide resolved
src/indexer/repository/transfer.ts Outdated Show resolved Hide resolved
tcar121293
tcar121293 requested changes Aug 10, 2023
View reviewed changes
src/indexer/repository/transfer.ts Outdated Show resolved Hide resolved
mpetrun5
mpetrun5 requested changes Aug 14, 2023
View reviewed changes
src/indexer/repository/transfer.ts Outdated Show resolved Hide resolved
src/indexer/services/evmIndexer/ofac/index.ts Outdated Show resolved Hide resolved
src/indexer/utils/evm/index.ts Outdated Show resolved Hide resolved
src/services/transfers.service.ts Outdated Show resolved Hide resolved
mpetrun5
mpetrun5 requested changes Aug 21, 2023
View reviewed changes
src/indexer/repository/transfer.ts Show resolved Hide resolved
src/indexer/utils/evm/index.ts Show resolved Hide resolved
src/indexer/utils/substrate/index.ts Show resolved Hide resolved
tcar121293
tcar121293 requested changes Aug 22, 2023
View reviewed changes
src/indexer/utils/substrate/index.ts Outdated Show resolved Hide resolved
src/indexer/utils/substrate/index.ts Show resolved Hide resolved
@wainola
Copy link
Contributor Author

wainola commented Aug 24, 2023

@MakMuftic @mpetrun5 @tcar121293 wdyt to change the attr accountId to sender on the schema?

@wainola wainola requested a review from mpetrun5 August 24, 2023 02:18
mpetrun5
mpetrun5 approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On renaming I am fine either way.

@wainola wainola requested a review from mpetrun5 August 30, 2023 01:29
@wainola wainola mentioned this pull request Aug 30, 2023
Merged
9 tasks
@wainola wainola merged commit 9c1eda2 into main Sep 11, 2023
5 checks passed
@wainola wainola deleted the fea/ofac-impl branch September 11, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@mpetrun5 mpetrun5 mpetrun5 approved these changes

@tcar121293 tcar121293 tcar121293 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add boolean property to OFAC addresses
4 participants
@wainola @tcar121293 @mpetrun5 @MakMuftic