Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add e2e test #97

Merged
merged 3 commits into from
Aug 10, 2023
Merged

chore: add e2e test #97

merged 3 commits into from
Aug 10, 2023

Conversation

tcar121293
Copy link
Contributor

@tcar121293 tcar121293 commented Aug 8, 2023

add e2e test

Description

added e2e test that fetches all transfers

Related Issue Or Context

Closes:

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@tcar121293 tcar121293 marked this pull request as draft August 8, 2023 14:45
@tcar121293 tcar121293 marked this pull request as ready for review August 9, 2023 11:18
@mpetrun5
Copy link
Contributor

mpetrun5 commented Aug 9, 2023

I wouldn't say this closes the issue. This is only creates the setup.
For the issue to be closed I would like for each transfer type the API for detail of that transfer be called and checked for all the relevant fields.

@MakMuftic
Copy link
Contributor

MakMuftic commented Aug 9, 2023

I wouldn't say this closes the issue. This is only creates the setup. For the issue to be closed I would like for each transfer type the API for detail of that transfer be called and checked for all the relevant fields.

I agree here with @mpetrun5 - I would leave issue as it is and just close this PR without closing issue.

Copy link
Contributor

@MakMuftic MakMuftic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tcar121293 just remove issue reference before merging

@tcar121293 tcar121293 merged commit d2aecbc into main Aug 10, 2023
5 checks passed
@tcar121293 tcar121293 deleted the tcar/e2e-tests branch August 10, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants