Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omit preventDefault in handleMouseWheel if allowZoom or allowWheel prop is false #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apomelitos
Copy link
Contributor

Hey, @sylvaindubus!

I'd like to have the ability to scroll a parent container while the cursor is over PrismaZoom and the allowWheel={false}
The objective is to have the capability to enable either zoom or parent container scroll.
In my case, I have a list of images that users can scroll. When the Shift key is held user should be able to zoom the hovered image. Scroll should be enabled after the Shift key is released.

Please take a look and let me know if I missed something.
Thanks in advance!

@apomelitos apomelitos closed this May 22, 2024
@sylvaindubus
Copy link
Owner

Sorry, I've just seen the notification of the closed PR.

Seems good to me. Would you mind checking if doing the same permutation for handleMouseStart, handleMouseMoveand handleDoubleClick creates unwanted side effects?

Thanks for your contribution!

@sylvaindubus sylvaindubus reopened this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants